Added paths option to resolve stdlib imports in IDE's #637
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
reviewed
Jun 7, 2019
|
|
||
| // @ts-ignore: decorator | ||
| @inline const BUFFERED_MASK: u32 = 1 << (sizeof<u32>() * 8 - 1); | ||
| @inline const BUFFERED_MASK: u32 = 1 << ((sizeof<u32>() * 8) - 1); |
Member
There was a problem hiding this comment.
this unnecessary. Multiply already have bigger precedence than subtraction
Contributor
Author
There was a problem hiding this comment.
I know but the syntax confused my IDE.
MaxGraey
reviewed
Jun 7, 2019
| declare function __visit_globals(cookie: u32): void; | ||
| declare function __visit_members(ref: usize, cookie: u32): void; | ||
| declare function __allocArray(length: i32, alignLog2: usize, id: u32, data?: usize): usize; | ||
| declare const ASC_RTRACE: boolean; |
Member
There was a problem hiding this comment.
note that this is actually not present at all without --use ASC_RTRACE=1, and meant to be used as isDefined(ASC_RTRACE).
Contributor
Author
There was a problem hiding this comment.
Which is my I thought it best to put here since this is the folder where it is referenced and so IDE's will use it. And it seemed like an internal definition so I didn't want to put it in the higher level file.
Member
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently IDE's can't resolve stdlib imports that aren't relative. This uses the ts path compiler option to try to resolve non-relative paths with the stdlib.
This also fixes two typing errors that IDE found.